spec: Clarify feedback noisiness
The old wording could be interpreted as the feedback being discarded if it's noisier than the currently selected profile which is not the case. Also take the new per application settings into account.
View Articledata: Drop outdated comment
We use the hints since some time, see lfb_event_set_feedback_profile().
View Articlelfb-event: Notify state change before completing async task
lfb_event_trigger_feedback_async() internally uses a GTask to handle invocation of the user provided callback when g_task_return_*() is called. Currently GTask is completed first and only afterwards...
View ArticleUse g_error() when library is not initalized
This makes sure it still works when asserts are disabled.
View ArticleMerge branch 'cleanups' into 'main'
Some cleanups I noticed while looking at the code See merge request !79
View Articlefeedback-manager: Use guint for event id
The ID is inserted into a hashtable below with GUINT_TO_POINTER and is set using self->next_id++ with next_id also being a guint, so change the type accordingly.
View Articlerun: Make it easy to run under gdb and document usage
Having a fast and easy way to run the daemon under gdb can be beneficial for debugging. For that start the run script with FBD_GDB=1.
View ArticleMerge branch 'misc_cleanups' into 'main'
Misc cleanup and ease running feedbackd under gdb See merge request !81
View Articletests/integration: Indicate that callback quits main loop
on_event_triggered() is renamed to on_event_triggered_quit() as we will shortly introduce a variant that does not quit.
View Articletests/integration: Fix whitespace
Remove all tabs in favour of spaces and align function arguments.
View Articletests/integration: Test that "feedback-ended" is propagated through LfbEvent
When no feedbacks are available (either because the requested event does not exist in the theme or because the system does not have required capabilities, e.g. no vibration motor or LED) feedbackd...
View Articlefeedback-manager: Complete DBus call before emitting "feedback-ended"
See previous commit adding the test (that now passes) for the reasoning. Fixes: #62
View Article